Add a new spelling for module map files 'module.modulemap'

Dmitri Gribenko gribozavr at
Tue Mar 18 10:19:05 PDT 2014

On Tue, Mar 18, 2014 at 4:52 PM, Ben Langmuir <blangmuir at> wrote:
> Thanks Argyrios.  Richard & Dmitri: just to confirm - are you okay with me
> committing this now, or did either of you intend to review the patch first?

+  // For frameworks, the preferred spelling is Modules/module.modulemap.
+  // Otherwise it is just module.modulemap.

... Otherwise it is just "" at the framework root.

Apart from that, two comments:

1. There is also the "" thing.  Do we want to rename
that file as well?

2. I don't immediately see how DirectoryHasModuleMap interacts with
frameworks now.  Does it contain only root framework directories or
'Module' subdirectories as well?  Could you add a sub framework test
to test this logic in hasModuleMap?


(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at>*/

More information about the cfe-commits mailing list