[PATCH] Always add LLVMgold.so plugin if it's present in the standard location

[Tom Roeder]

On Mon, Feb 24, 2014 at 10:46 AM, Chandler Carruth <chandlerc at google.com>wrote:

>
> On Mon, Feb 24, 2014 at 10:43 AM, Tom Roeder <tmroeder at google.com> wrote:
>
>> I agree that we probably should leave the default behavior as it is.
>> Are you opposed to adding the always-pass-gold feature behind a build
>> flag?
>>
>
> My inclination would be to provide a generic driver flag that does this.
> Then -flto can just imply this flag when linking, but folks who know they
> are using gold can pass it directly.
>
> Not sure if we really need a build-time parameter to toggle the default
> here (I personally don't see a need, but perhaps others do).
>

Sorry for the delay in response here.

If the choice must be made explicitly by the caller of the compiler, then
any custom build rules that call the compiler in unusual ways must be
modified to pass the right flag, be it a driver flag or a consequence of
-flto. This can be unnecessarily painful in large code bases. So, I'd
really like to be able to toggle the default mode for the compiler.

I'd be very interested to hear the opinions of others, though.

Tom
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140314/f76e2220/attachment.html>