[PATCH] Add SourceRange to err_not_tag_in_scope diagnostic in TreeTransform<...>::RebuildDependentNameType

Stephan Tolksdorf st at quanttec.com
Wed Mar 12 11:07:13 PDT 2014


Hi rsmith,

Apparently the FIXME was overlooked when the source location information was
made available to the function.

http://llvm-reviews.chandlerc.com/D3058

Files:
  lib/Sema/TreeTransform.h

Index: lib/Sema/TreeTransform.h
===================================================================
--- lib/Sema/TreeTransform.h
+++ lib/Sema/TreeTransform.h
@@ -952,9 +952,8 @@
           break;
         }
         default:
-          // FIXME: Would be nice to highlight just the source range.
           SemaRef.Diag(IdLoc, diag::err_not_tag_in_scope)
-            << Kind << Id << DC;
+              << Kind << Id << DC << QualifierLoc.getSourceRange();
           break;
       }
       return QualType();
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D3058.1.patch
Type: text/x-patch
Size: 511 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140312/4564f3a5/attachment.bin>


More information about the cfe-commits mailing list