[PATCH] Support case insensitive header searches for MSVCCompat

Nico Weber thakis at chromium.org
Wed Mar 12 09:11:07 PDT 2014


Given that r203614 is in and this patch is the same kind of thing, I
retract my being opposed to this patch.


On Thu, Mar 6, 2014 at 2:29 PM, David Majnemer <david.majnemer at gmail.com>wrote:

> Modulo needing some style fixes, this looks fine. However, I'd prefer
> for @rsmith look at this at least to make sure it plays nice with modules.
>
>
> On Wed Mar 05 2014 at 1:18:22 PM, Nico Weber <thakis at chromium.org> wrote:
>
>> The compiler won't be the only place with issues like this though, no?
>> Say you have a generated header "header.h" and some file accidentally
>> includes it as "Header.h", then the build system now won't have a correct
>> dependency edge. There's probably more examples.
>>
>> Can't you just create a case-insensitive file system even in cross mode?
>>
>>
>> On Wed, Mar 5, 2014 at 1:13 PM, Saleem Abdulrasool <abdulras at fb.com>wrote:
>>
>>>
>>>   One of the nice things about clang is that it is inherently a
>>> cross-compiler :-).  Not all file systems are case-insensitive, and
>>> unfortunately, as I mentioned in the commit message, the Windows SDK does
>>> get the case wrong in many cases.  This is an attempt to make the
>>> cross-compiler work properly with MS compatibility irrespective of the
>>> environment where it is being executed.
>>>
>>> http://llvm-reviews.chandlerc.com/D2972
>>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140312/f7877813/attachment.html>


More information about the cfe-commits mailing list