[PATCH] Fix uninitialized value in AttributedTypeLoc.

Logan Chien tzuhsiang.chien at gmail.com
Sun Mar 9 09:10:52 PDT 2014


Hi Aaron,

Sorry.  I have uploaded the test case to the Phabricator.  Now I attached
the test case in the email.

I have tried to trigger the issue with -ast-dump (or something similar) but
failed.  It seems that getAttrEnumOperandLoc() is only used by ASTReader,
ASTWriter, and TransGCAttrs.  None of them will try to print the source
location to the output.  Do you have any idea?  Thanks.

Sincerely,
Logan


On Mon, Mar 10, 2014 at 12:01 AM, Aaron Ballman <aaron.ballman at gmail.com>wrote:

> I don't see anything attached to your email, but I don't think crashes
> aren't required for a test case for this. The behavior I was thinking
> of testing is that the old code would fail to set the operand location
> properly for the type attribute, and the new case does set it. So any
> case which relies on that location being set to something valid would
> suffice.
>
> ~Aaron
>
> On Sun, Mar 9, 2014 at 11:55 AM, Logan Chien <tzuhsiang.chien at gmail.com>
> wrote:
> >
> >   If you are interested in, here's reduced test case.  It was reduced
> from the Android jni.h.  I feel this test is not good enough because clang
> will not crash if you delete some of the lines in crash_pch.h.
> >
> >   {F47242}
> >
> > http://llvm-reviews.chandlerc.com/D3020
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140310/793dc7cd/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pch-crash.zip
Type: application/zip
Size: 1587 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140310/793dc7cd/attachment.zip>


More information about the cfe-commits mailing list