[PATCH] [C++11] Remove the remaining uses of OwningPtr.

David Blaikie dblaikie at gmail.com
Sat Mar 8 22:48:46 PST 2014



================
Comment at: examples/clang-interpreter/main.cpp:19
@@ -18,3 +18,2 @@
 #include "clang/Frontend/TextDiagnosticPrinter.h"
-#include "llvm/ADT/OwningPtr.h"
 #include "llvm/ADT/SmallString.h"
----------------
Ahmed Charles wrote:
> David Blaikie wrote:
> > It'd be nice to include <memory> whenever it's needed rather than relying on indirect inclusion.
> I could replace each include of OwningPtr with <memory> but that wouldn't actually make your desire come true, it would only reduce the likelihood that I introduce transient build breaks with this change that are easy to fix.
> 
> Unless there's a tool I can run to verify this, it's just going to result in me sprinkling the code with lots of <memory> 'love'. :)
Sure - but it seems a step back to move towards having fewer necessary inclusions, so I'd advocate just swapping OwningPtr.h to <memory> (you could use Chandler's sort includes script to get it back in the right spot rather than having to move it to the bottom in each case)


http://llvm-reviews.chandlerc.com/D3015



More information about the cfe-commits mailing list