[PATCH] Deduplicate clang-tidy error messages by file, offset and message.

Alexander Kornienko alexfh at google.com
Thu Mar 6 09:42:07 PST 2014


On Thu, Mar 6, 2014 at 6:23 PM, Manuel Klimek <klimek at google.com> wrote:

>
> On Mar 6, 2014 6:16 PM, "Alexander Kornienko" <alexfh at google.com> wrote:
> > +    if (M1.FileOffset < M2.FileOffset)
> > +      return true;
> > +    if (M1.FileOffset > M2.FileOffset)
> > +      return false;
>
> I'd write those as:
> If (a != b)
>   Return a < b;
>
Yep, that's much better. Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140306/ce6a7e4f/attachment.html>


More information about the cfe-commits mailing list