r202989 - [C++11] Using std::unique_ptr to ensure that Argument objects do not leak (since clang-tblgen isn't long-lived, the old leak is probably acceptable, but it offended my senses nonetheless).

Aaron Ballman aaron at aaronballman.com
Wed Mar 5 09:20:50 PST 2014


On Wed, Mar 5, 2014 at 12:19 PM, Jordan Rose <jordan_rose at apple.com> wrote:
> IIRC TableGen has plenty of leaks, but I agree on the principle of the
> thing.

That's my understanding as well. But since I'm usually the one in this
file, and it doesn't bother me from a maintenance perspective, I
figured it'd be a nice exercise in cleaning things up. Plus, C++11 is
so much fun. ;-)

~Aaron



More information about the cfe-commits mailing list