[PATCH] [CMake] Resurrect add_dependencies() and target_link_libraries()

[NAKAMURA Takumi]

2014-02-28 11:39 GMT+09:00 Rafael Espíndola <rafael.espindola at gmail.com>:
> This will always use INTERFACE. The current setup has logic for
> deciding between INTERFACE, PUBLIC and PRIVATE. Wont this produce the
> wrong result when doing shared builds?

I guess this patch would make it non-extensible. But I don't care about it.

> What I had in mind was defining a LLVM_LINK_TYPE that is INTERFACE,
> PUBLIC or PRIVATE depending on the build type. Is that possible?

I think link type would depend on relationship between linker and linkee.
Each library might be STATIC or SHARED.
(This was one of reasons why I took target_link_libraries under control)

> I was looking at AddLLVM.cmake, but I don't quite understand it. For
> example, where is ARG_MODULE set?

ARG_XXX is set by cmake_parse_arguments(ARG ...).