r202181 - Pretty Printer: Print constexpr and ref qualifiers. Don't print return types on destructors.

Benjamin Kramer benny.kra at gmail.com
Wed Feb 26 02:30:32 PST 2014


On 26.02.2014, at 10:17, Dmitri Gribenko <gribozavr at gmail.com> wrote:

> On Tue, Feb 25, 2014 at 6:49 PM, Benjamin Kramer
> <benny.kra at googlemail.com> wrote:
>> TEST(DeclPrinter, TestCXXConstructorDecl8) {
>> @@ -519,8 +518,7 @@ TEST(DeclPrinter, TestCXXConstructorDecl
>>     "  A(T&&... ts) : T(ts)... {}"
>>     "};",
>>     constructorDecl(ofClass(hasName("A"))).bind("id"),
>> -    "A<T...>(T &&ts...) : T(ts)"));
>> -    // WRONG; Should be: "A(T&&... ts) : T(ts)..."
>> +    "A<T...>(T &&ts...) : T(ts)..."));
>> }
> 
> Note that the (T &&ts...) part does not look correct, "..." is still
> in the wrong place.  If you agree, please put back "WRONG".

Right, I was a bit too aggressive removing WRONGs here. Put it back in r202255.

- Ben





More information about the cfe-commits mailing list