Add 'remark' diagnostic type in clang

David Majnemer david.majnemer at gmail.com
Tue Feb 25 02:32:34 PST 2014


You've added some extra whitespace in the definition
of CXDiagnosticSeverity.
Perhaps more importantly, the enum isn't in increasing order anymore.

On Tue Feb 25 2014 at 2:22:14 AM, Tobias Grosser <tobias at grosser.es> wrote:

> Hi,
>
> I would like to add the following patch. (I submitted a corresponding
> patch to LLVM).
>
> --------------
> Add 'remark' diagnostic type in clang
>
> A 'remark' is information that is not an error or a warning, but rather
> some additional information provided to the user. In contrast to a
> 'note' a 'remark' is an independent diagnostic, whereas a 'note' always
> depends on another diagnostic.
>
> A typical use case for remark nodes is information provided to the user,
> e.g. information provided by the vectorizer about loops that have been
> vectorized.
> --------------
>
> A review would be highly appreciated.
>
> Tobias
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140225/47cede5d/attachment.html>


More information about the cfe-commits mailing list