[PATCH] Added CXXMethodDecl matcher isPureVirtual()

Konrad Kleine konrad.wilhelm.kleine at gmail.com
Mon Feb 24 01:09:01 PST 2014


Here's the Differential in phabricator:
http://llvm-reviews.chandlerc.com/D2865 I hope you don't mind that I've
added you both (Manuel and Dimitri) as reviewers.


2014-02-24 10:03 GMT+01:00 Konrad Kleine <konrad.wilhelm.kleine at gmail.com>:

> Hi Manuel,
>
> you're right. A method cannot be pure without being virtual. I think it is
> safe to remove the Node.isVirtual() call and change the matcher to
> "isPure". I'll try create a phabricator diff for this.
>
> Thank you so far for the review.
>
>
> 2014-02-23 20:43 GMT+01:00 Manuel Klimek <klimek at google.com>:
>
> Can a method be pure without being virtual?
>>
>>
>> On Fri, Feb 21, 2014 at 5:30 PM, Dmitri Gribenko <gribozavr at gmail.com>wrote:
>>
>>> On Fri, Feb 21, 2014 at 4:24 PM, Konrad Kleine
>>> <konrad.wilhelm.kleine at gmail.com> wrote:
>>> > Hi,
>>> >
>>> > I've added a new CXXMethodDecl matcher: isPureVirtual().
>>>
>>> + Manuel
>>>
>>> --
>>> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
>>> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
>>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140224/972d697c/attachment.html>


More information about the cfe-commits mailing list