[patch] Always open files in binary mode

NAKAMURA Takumi geek4civic at gmail.com
Sun Feb 23 23:32:21 PST 2014

I guess it'd be fine, as far as I tested.
I don't know since when Win32 console was capable of handling \n w/o O_TEXT...
I wondered CMD.EXE's "TYPE foo.ll" is working with '\n' ...

It means we shouldn't use Wide APIs to stdout any more.
I still wonder how we could handle m17n on win32...
(In contrast, stderr is left O_TEXT (obey local codepage))

2014-02-24 11:25 GMT+09:00 Rafael EspĂ­ndola <rafael.espindola at gmail.com>:
> It looks like everything on windows these days can handle unix line endings.
> I tested that the llvm and clang testsuite work. I also tested that
> printing to stdout is readable with "clang -S -o - foo.c".
> Cheers,
> Rafael

More information about the cfe-commits mailing list