[PATCH] [Win32 ABI] Defer operator delete check until vtable is marked used

Richard Smith richard at metafoo.co.uk
Sun Feb 23 16:17:28 PST 2014


  Looks great, thanks!


================
Comment at: lib/Sema/SemaDeclCXX.cpp:12342
@@ +12341,3 @@
+    // checks (i.e. operator delete() lookup) when the vtable is marked used, as
+    // any translation unit may need to emit a deleting destructor.
+    // If it has a definition, we do the check at that point instead.
----------------
Maybe...

"as the deleting destructor is emitted with the vtable, not with the destructor definition"

?


http://llvm-reviews.chandlerc.com/D2851



More information about the cfe-commits mailing list