Dead assignment deletion

Gautier DI FOLCO gautier.difolco at
Sun Feb 23 14:58:44 PST 2014


I wanted to contribute to some FOSS projects and when I followed Sylvestre
LEDRU's talk during FOSDEM, it has appeared to me that there were some
simple tasks to do on Clang, so it would be a good starting point.

So I'm gone on, looking for some
dead assignments to delete.
I have found one in clang /lib /Sema /SemaObjCProperty.cpp on line 1819.
I have checkout the projects (at revision 201990), built them once, I have
ran the clang's test suite, which give me :

gmake[1]: Entering directory `/usr/home/black/build/tools/clang/test'
Making Clang '' file...
Making Clang 'Unit/' file...
--- Running clang tests for x86_64-unknown-freebsd9.2 --- lit.cfg:196: note: using clang:
Testing Time: 313.95s
  Expected Passes    : 6939
  Expected Failures  : 20
  Unsupported Tests  : 15
gmake[1]: Leaving directory `/usr/home/black/build/tools/clang/test'

I have then dropped the line, rebuilt the projects, I have relaunched tests
and I have had the same results.

I don't know if I follow the rules, I'm sorry if I don't and I will take
any links which can explains me how to follow them.

It is not a big contribution but I want to do many small ones to immerse
myself into this projet. If you think that there is easy tasks more useful
to do, let me know. If this first contribution is a success, I have planned
to drop the majority of bugs in this list, so do you think it is wise to do
one patch for each "line" or a bigger patch which will aggregate 10 of them?

Thank you for your time,
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dead-assignment.patch
Type: text/x-patch
Size: 586 bytes
Desc: not available
URL: <>

More information about the cfe-commits mailing list