r201962 - Remove support for the QA_OVERRIDE_GCC3_OPTIONS environment variable.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Sun Feb 23 06:08:26 PST 2014


Thanks!

On 22 February 2014 19:11, Bob Wilson <bob.wilson at apple.com> wrote:
> Author: bwilson
> Date: Sat Feb 22 18:11:56 2014
> New Revision: 201962
>
> URL: http://llvm.org/viewvc/llvm-project?rev=201962&view=rev
> Log:
> Remove support for the QA_OVERRIDE_GCC3_OPTIONS environment variable.
>
> In r199283 I switched the name of this variable to CCC_OVERRIDE_OPTIONS, but
> I kept some code to continue recognizing the old name temporarily. As far as
> I know, the only use of this was for some internal testing at Apple, and we've
> now switched to use the new name. If anyone else is still using this and needs
> more time to switch names, I guess we'll find out! <rdar://problem/15821425>
>
> Modified:
>     cfe/trunk/test/Driver/qa_override.c
>     cfe/trunk/tools/driver/driver.cpp
>
> Modified: cfe/trunk/test/Driver/qa_override.c
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/qa_override.c?rev=201962&r1=201961&r2=201962&view=diff
> ==============================================================================
> --- cfe/trunk/test/Driver/qa_override.c (original)
> +++ cfe/trunk/test/Driver/qa_override.c Sat Feb 22 18:11:56 2014
> @@ -1,7 +1,5 @@
>  // RUN: env CCC_OVERRIDE_OPTIONS="#+-Os +-Oz +-O +-O3 +-Oignore +a +b +c xb Xa Omagic ^-###  " %clang -target x86_64-apple-darwin %s -O2 b -O3 2>&1 | FileCheck %s
>  // RUN: env CCC_OVERRIDE_OPTIONS="x-Werror +-msse" %clang -target x86_64-apple-darwin -Werror %s -c -### 2>&1 | FileCheck %s -check-prefix=RM-WERROR
> -// RUN: env QA_OVERRIDE_GCC3_OPTIONS="#+-Os +-Oz +-O +-O3 +-Oignore +a +b +c xb Xa Omagic ^-###  " %clang -target x86_64-apple-darwin %s -O2 b -O3 2>&1 | FileCheck %s
> -// RUN: env QA_OVERRIDE_GCC3_OPTIONS="x-Werror +-msse" %clang -target x86_64-apple-darwin -Werror %s -c -### 2>&1 | FileCheck %s -check-prefix=RM-WERROR
>
>  // CHECK: "-cc1"
>  // CHECK-NOT: "-Oignore"
>
> Modified: cfe/trunk/tools/driver/driver.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/driver/driver.cpp?rev=201962&r1=201961&r2=201962&view=diff
> ==============================================================================
> --- cfe/trunk/tools/driver/driver.cpp (original)
> +++ cfe/trunk/tools/driver/driver.cpp Sat Feb 22 18:11:56 2014
> @@ -331,14 +331,10 @@ int main(int argc_, const char **argv_)
>    }
>
>    // Handle CCC_OVERRIDE_OPTIONS, used for editing a command line behind the
> -  // scenes. Temporarily accept the old QA_OVERRIDE_GCC3_OPTIONS name
> -  // for this, to ease the transition. FIXME: Remove support for that old name
> -  // after a while.
> +  // scenes.
>    if (const char *OverrideStr = ::getenv("CCC_OVERRIDE_OPTIONS")) {
>      // FIXME: Driver shouldn't take extra initial argument.
>      ApplyQAOverride(argv, OverrideStr, SavedStrings);
> -  } else if (const char *OverrideStr = ::getenv("QA_OVERRIDE_GCC3_OPTIONS")) {
> -    ApplyQAOverride(argv, OverrideStr, SavedStrings);
>    }
>
>    std::string Path = GetExecutablePath(argv[0], CanonicalPrefixes);
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



More information about the cfe-commits mailing list