[libcxx][PATCH] remove implementation of fmaf - fix for PR18910

Marshall Clow mclow.lists at gmail.com
Sat Feb 22 07:44:04 PST 2014


Remove the implementation of "std:::fmaf” from libc++’s <cmath> header, and use the c library’s one instead.

I believe this bug is a historical relic from the early days of libc++ implementation.
It was part of the original libc++ checkin to the LLVM repo.
Probably very old versions of Apple’s C library were based on C89, which didn’t have fmaf, and so Howard just provided this here.
[ When I say very old, I mean in the Mac OS X 10.3/10.4 timeframe ]

Now we have C99 libraries in most places, and they all (as far as I can tell) provide fmaf themselves, and (I think) we can remove this.

If you’re running on a system that has an older C library implementation, this could be a breaking change, and I want to know about it.
I can put this code back under an #ifdef for those systems, but not if I don’t know which systems they are.

— Marshall

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 18910.patch
Type: application/octet-stream
Size: 548 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140222/6b96cc96/attachment.obj>

More information about the cfe-commits mailing list