[PATCH] Add a VFSFromYAML class and a parser to create it

Ben Langmuir blangmuir at apple.com
Fri Feb 21 15:18:40 PST 2014



================
Comment at: unittests/Basic/VirtualFileSystemTest.cpp:253-254
@@ +252,4 @@
+
+TEST(VirtualFileSystemTest, MappedFiles) {
+  NumDiagnostics = 0;
+  IntrusiveRefCntPtr<DummyFileSystem> Lower(new DummyFileSystem());
----------------
Dmitri Gribenko wrote:
> You could use TEST_F to create a test fixture.  Then you don't need a variable with a static lifetime, since you can hang it on the instance of the fixture.
> 
Cool, I'll make that a separate commit.  At the moment there is no way to pass through the necessary context parameter to the diagnostic handler.


http://llvm-reviews.chandlerc.com/D2835

BRANCH
  vfs/patch3-yaml

ARCANIST PROJECT
  clang



More information about the cfe-commits mailing list