[PATCH] clang: forward -no-integrated-as from the driver

David Woodhouse dwmw2 at infradead.org
Fri Feb 21 07:29:47 PST 2014

On Fri, 2014-02-21 at 10:02 -0500, Rafael EspĂ­ndola wrote:
> OK, this is going a bit off topic for this code review. What this
> patch does is disable the integrated assembler completely when
> -no-integrated-as is given. Both for -S and -c. I think you agree that
> that is the correct behavior.

Yes, it's a good start.

> Another possible change would be for the driver to make -S imply
> -no-integrated assembler. That is far more contentious and should have
> a code review of its own.


I think the idea of checking for missing constraints is a good one, but
unless you do make '-S' disable it completely, it's very important to
have a non-catastrophic failure mode.

If 'clang -S' can't parse the inline asm, then it should just silently
decline to check for missing constraints, or do the other cool things
you suggested. It should *not* break the build as seen in bug 18891.

I'd accept the failure mode being fixed, instead of completely disabling
the feature when -S is used.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5745 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140221/adb1a22d/attachment.bin>

More information about the cfe-commits mailing list