[PATCH] Hide pragma handler classes in ParsePragma.cpp

Juergen Ributzka juergen at apple.com
Thu Feb 20 16:10:11 PST 2014


Clang commits is a little slow today. It hasn’t shown up in my inbox yet, but I see that it is currently compiling.

On Feb 20, 2014, at 4:07 PM, Reid Kleckner <rnk at google.com> wrote:

> Should have been fixed by r201825.
> 
> 
> On Thu, Feb 20, 2014 at 3:54 PM, Juergen Ributzka <juergen at apple.com> wrote:
> On of your recent pragma changes broke our internal build.
> 
> ******************** TEST 'Clang Tools :: pp-trace/pp-trace-pragma-ms.cpp' FAILED ********************
> Script:
> --
> pp-trace -ignore FileChanged,MacroDefined src/tools/clang/tools/extra/test/pp-trace/pp-trace-pragma-ms.cpp -target x86_64 -fms-extensions -w | FileCheck --strict-whitespace src/tools/clang/tools/extra/test/pp-trace/pp-trace-pragma-ms.cpp
> --
> Exit Code: 1
> 
> Command Output (stderr):
> --
> src/tools/clang/tools/extra/test/pp-trace/pp-trace-pragma-ms.cpp:23:16: error: expected string not found in input
> // CHECK-NEXT: - Callback: PragmaComment
>                ^
> <stdin>:5:1: note: scanning from here
> - Callback: PragmaDirective
> ^
> 
> Could you please take a look?
> 
> Thanks
> 
> Cheers,
> Juergen
> 
> On Feb 20, 2014, at 2:59 PM, Reid Kleckner <rnk at google.com> wrote:
> 
> >
> >  Closed by commit rL201820 (authored by @rnk).
> >
> > CHANGED PRIOR TO COMMIT
> >  http://llvm-reviews.chandlerc.com/D2834?vs=7219&id=7260#toc
> >
> > http://llvm-reviews.chandlerc.com/D2834
> >
> > COMMIT
> >  http://llvm-reviews.chandlerc.com/rL201820
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140220/6003d854/attachment.html>


More information about the cfe-commits mailing list