[PATCH] Complete Rewrite of CGRecordLayoutBuilder
Yunzhong_Gao at playstation.sony.com
Wed Feb 19 17:41:32 PST 2014
A coding style question:
It seems that CGRecordLowering is exposing a lot of its member fields and functions. I wonder whether it makes sense to make some of these member fields private. For example, it seems
does not need to be referenced by outside classes, and could be made private (and hence the definition of MemberInfo). I did not check all the "Input Memoization fields", but I suspect some of them do not need to be exposed either. And some of the member functions as well, such as,
and some other functions used by lower(), probably can be hidden from outside classes as well.
I think this is minor point since CGRecordLowering is only defined and used in this file, and I am not entirely sure about LLVM's coding style on access control. What do the other reviewers think?
More information about the cfe-commits