r201604 - clang-cl /fallback: emit a note when falling back
hans at chromium.org
Tue Feb 18 18:16:30 PST 2014
On Tue, Feb 18, 2014 at 5:47 PM, Chandler Carruth <chandlerc at google.com> wrote:
> On Tue, Feb 18, 2014 at 3:33 PM, Hans Wennborg <hans at chromium.org> wrote:
>> On Tue, Feb 18, 2014 at 3:08 PM, Reid Kleckner <rnk at google.com> wrote:
>> > We don't generally emit notes that aren't attached to warnings. This
>> > seems
>> > fine to me in this instance.
>> Yes, I figured printing a warning or error would be weirder though.
>> One other place where we print a note like this is when preparing
>> crash reports. I think this situation is kinda similar.
> I would much prefer a warning.
> Notes are routinely skipped entirely by parsing logic unless attached to a
> warning or other diagnostic.
Sure, fixed in r201626.
More information about the cfe-commits