[PATCH] Append CXXDefaultInitExpr's wrapped expression to the CFG when visiting a constructor initializer

Richard Smith richard at metafoo.co.uk
Fri Feb 14 12:52:41 PST 2014


On Fri, Feb 14, 2014 at 12:15 PM, Enrico Pertoso <epertoso at google.com>wrote:

> No, I don't have commit access.
>
> Although the tests are passing, I'd still like to clarify the
> unreachable code warnings:
>
> The code in Richard's example doesn't generate a warning. Should it?
>

It shouldn't, and indeed there's no reason why it would, because we don't
propagate constant values around during AnalysisBasedWarnings. Sorry for
not thinking this all the way through! =)


> I could also try to spend another couple of days to see how the
> unreachable code warnings are generated and make sure we're not doing
> it when we shouldn't.


No need, IMO. I'll try to remember to commit the patch in a few days if
no-one gets there first =)


> On Thu, Feb 13, 2014 at 6:21 PM, Jordan Rose <jordan_rose at apple.com>
> wrote:
> >
> >   This looks good to me. Do you have commit access, or do you need one
> of us to commit it for you?
> >
> > http://llvm-reviews.chandlerc.com/D2370
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140214/60d596ba/attachment.html>


More information about the cfe-commits mailing list