[PATCH] [ARM] Fix NEON being enabled with soft-float

[James Molloy]

Hi Amara, Renato,

Amara asked me to take a look at this too - it looks fine. The addition of
-crypto should be a noop if crypto was disabled already, and will disable it
if it would be automatically enabled in LLVM (outside the scope of the clang
driver).

Renato, could you explain your objections a little more please? I'm not sure
I fully understand.

Cheers,
James

> -----Original Message-----
> From: cfe-commits-bounces at cs.uiuc.edu [mailto:cfe-commits-
> bounces at cs.uiuc.edu] On Behalf Of Renato Golin
> Sent: 11 February 2014 12:37
> To: t.p.northover at gmail.com; Amara Emerson
> Cc: cfe-commits at cs.uiuc.edu
> Subject: Re: [PATCH] [ARM] Fix NEON being enabled with soft-float
> 
> 
>   Wouldn't getARMTargetFeatures() be called for both targets? If you call
> clang with -target arm and no neon, would that also add -crypto to it?
> 
>   Maybe having a check on an ARM test earlier would make things clearer
> (like CHECK-NOT: -crypto).
> 
> http://llvm-reviews.chandlerc.com/D2736
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits