r201183 - Remove bad debug info test.

Adrian Prantl aprantl at apple.com
Tue Feb 11 13:49:43 PST 2014


Hi David,

a second ago I replied to your previous mail:-) I’d like to ask you to revert this commit and rather update the testcase to do something more meaningful instead. See my other mail for details.

thanks and sorry for the delay,

adrian


On Feb 11, 2014, at 13:37, David Blaikie <dblaikie at gmail.com> wrote:

> Author: dblaikie
> Date: Tue Feb 11 15:37:47 2014
> New Revision: 201183
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=201183&view=rev
> Log:
> Remove bad debug info test.
> 
> Another test that's testing through assembly from Clang which is
> problematic. An attempt to upgrade this to just be an IR-generation test
> was unsuccessful (I was unable to get this test to fail) but it looks
> like there's other, better, test coverage in this area
> (test/CodeGenObjC/debuginfo-properties.m) anyway.
> 
> Removed:
>    cfe/trunk/test/CodeGenObjC/debug-property-synth.m
> 
> Removed: cfe/trunk/test/CodeGenObjC/debug-property-synth.m
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenObjC/debug-property-synth.m?rev=201182&view=auto
> ==============================================================================
> --- cfe/trunk/test/CodeGenObjC/debug-property-synth.m (original)
> +++ cfe/trunk/test/CodeGenObjC/debug-property-synth.m (removed)
> @@ -1,20 +0,0 @@
> -// RUN: %clang_cc1 -triple %itanium_abi_triple -masm-verbose -S -g %s -o - | FileCheck %s
> -// Radar 9468526
> - at interface I {
> -  int _p1;
> -}
> - at property int p1;
> - at end
> -
> - at implementation I
> - at synthesize p1 = _p1;
> - at end
> -
> -int main() {
> -  I *myi;
> -  myi.p1 = 2;
> -  return 0;
> -}
> -
> -// FIXME: Make this test ir files.
> -// CHECK:       .loc    2 6 0
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits





More information about the cfe-commits mailing list