[PATCH] Pass -gdwarf-N options to integrated assembler

Renato Golin renato.golin at linaro.org
Tue Feb 11 11:08:37 PST 2014


On 11 February 2014 17:15, David Blaikie <dblaikie at gmail.com> wrote:
> This code appears to be untested - is that the case? Can we test it in some
> way? (it might necessarily be an IR level test, but just testing that the
> version in the generated DWARF is what was requested - I think that'd be
> OK... but open to debate/discussion on the matter)

Hi David,

The Dwarf version gets passed down there...

>> +  Ctx.setDwarfVersion(Opts.DwarfVersion);

Assuming the setDwarfVersion works correctly, this feature will also
work correctly.

I may be missing something, but IIRC it's not recommended to test what
gets passed down to the MC layer on Clang tests.

Are you suggesting we add tests to MC, too? That'd be good, I think,
but for another patch.

cheers,
--renato



More information about the cfe-commits mailing list