r201162 - 'nonnull(1)' on a block parameter should apply to the block's argument.

Jordan Rose jordan_rose at apple.com
Tue Feb 11 09:37:05 PST 2014


On Feb 11, 2014, at 9:36 , Aaron Ballman <aaron at aaronballman.com> wrote:

>> +    if (D->getFunctionType()) {
>> +      handleNonNullAttr(S, D, Attr);
>> +    } else {
>> +      S.Diag(Attr.getLoc(), diag::warn_attribute_nonnull_parm_no_args)
>> +        << D->getSourceRange();
>> +    }
> 
> Minor nit about the style -- shouldn't be using the curly braces here.

Uh...hm. I tried it without the curly braces, but it looked very strange with the << dangling there. Should I add a dummy comment to justify it?

Jordan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140211/0174a31c/attachment.html>


More information about the cfe-commits mailing list