[PATCH] Verify source files for a module only once during the build

Dmitri Gribenko gribozavr at gmail.com
Fri Feb 7 10:18:03 PST 2014


On Fri, Feb 7, 2014 at 6:14 PM, Ben Langmuir <blangmuir at apple.com> wrote:
> Hi Dmitri,
>
> +        // If we are reading a module, we will create a verification timestamp,
> +        // so we verify all input files.  Otherwise, verify only user input
> +        // files.
> +        unsigned LastFileToValidate =
> +            F.Kind == MK_Module ? F.InputFilesLoaded.size() : Record[1];
> +        for (unsigned I = 0; I < LastFileToValidate; ++I) {
>             InputFile IF = getInputFile(F, I+1, Complain);
>             if (!IF.getFile() || IF.isOutOfDate())
>
>
> Should that be
>
> MK_Module && SkipVerifyIfValidatedAfter ?
>
> or is it intentional to stat the system files even if this new command line option is missing?

Indeed, that was not intended.  Thanks!  Updated and rebased patch attached.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: optimize-module-verification-v3.patch
Type: application/octet-stream
Size: 16095 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140207/a4503e64/attachment.obj>


More information about the cfe-commits mailing list