[PATCH] Verify source files for a module only once during the build

Ben Langmuir blangmuir at apple.com
Fri Feb 7 10:14:30 PST 2014


Hi Dmitri,

+        // If we are reading a module, we will create a verification timestamp,
+        // so we verify all input files.  Otherwise, verify only user input
+        // files.                                                                                                  
+        unsigned LastFileToValidate =
+            F.Kind == MK_Module ? F.InputFilesLoaded.size() : Record[1];
+        for (unsigned I = 0; I < LastFileToValidate; ++I) {
            InputFile IF = getInputFile(F, I+1, Complain);
            if (!IF.getFile() || IF.isOutOfDate())


Should that be

MK_Module && SkipVerifyIfValidatedAfter ?

or is it intentional to stat the system files even if this new command line option is missing?

Ben 

On Feb 7, 2014, at 7:13 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:

> On Fri, Feb 7, 2014 at 2:07 PM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
>> Please review.
> 
> An unintended change to ASTUnit.cpp slipped in.  Correct patch attached.
> 
> Dmitri
> 
> -- 
> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
> <optimize-module-verification-v2.patch>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits




More information about the cfe-commits mailing list