r200640 - Report a correct end location for nameless parameters.

Jordan Rose jordan_rose at apple.com
Fri Feb 7 09:15:26 PST 2014


On Feb 7, 2014, at 4:31 , Benjamin Kramer <benny.kra at gmail.com> wrote:

> 
> On 03.02.2014, at 18:25, Jordan Rose <jordan_rose at apple.com> wrote:
> 
>> Can't we just always provide a RangeEnd? For single-token types it should be the same as the start location, but that's fine. (Assuming these are token ranges, not character ranges.)
> 
> Not sure if I understand. If the type has a name the range end should point at the name token. If we take the location from the type it won't cover the entire parameter.

Ah, I'm sorry, I misread the code to be a shortcut for types, not decls. Looks correct.

Jordan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140207/ec150838/attachment.html>


More information about the cfe-commits mailing list