r192494 - Adds Microsoft compatiable C++ record layout code to clang.

Will Wilson will at indefiant.com
Thu Feb 6 16:23:47 PST 2014


Hi Warren,

I've just been hunting a bug in MS mode where records were being given
different layouts depending on if the TU was built with a PCH or not. In
the end I tracked it down to ASTContext::getASTRecordLayout() introduced in
r192494:

  if (isMsLayout(D) && !D->getASTContext().getExternalSource()) {
    NewEntry = BuildMicrosoftASTRecordLayout(D);

Removing the "&& !D->getASTContext().getExternalSource()" restored the
expected behaviour. Is this check still needed?

Cheers,
Will.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140207/9963e1d3/attachment.html>


More information about the cfe-commits mailing list