[PATCH] Add a -verify-pch option to clang -cc1

[Eric Christopher]

As a note since I raised a (completely) question about your implementation
here you should have waited for an ack from me.
On Feb 5, 2014 2:31 PM, "Ben Langmuir" <blangmuir at apple.com> wrote:

>
> On Feb 5, 2014, at 8:11 AM, Argyrios Kyrtzidis <kyrtzidis at apple.com>
> wrote:
>
> > Sorry for the delay!
> >
> > On Jan 24, 2014, at 9:58 AM, Ben Langmuir <blangmuir at apple.com> wrote:
> >
> >> Based on an off-list discussion, I've updated this patch to not check
> for configuration mismatches (e.g. different langopts), since checking for
> staleness is the interesting case to check for and adding all the requisite
> langopts to the command line increases the complexity of using the feature.
> >
> > +  /// for configuration differences between the AST file and the
> invokation.
> >
> > typo: 'invocation'
>
> I don't know why, but I always spell invocation incorrectly the first
> time.  Good catch.
>
> >
> > Also this doesn't verify system headers, do you plan to do this after
> you commit this patch ?
> >
>
> Yep, I'll commit that separately.
>
> >
> > Otherwise, LGTM!
>
>
> Great, thank!  r200884
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140205/0102ef15/attachment.html>