[PATCH] Store warning option for custom diagnostic messages.

Alp Toker alp at nuanti.com
Thu Jan 30 11:05:37 PST 2014

On 30/01/2014 18:29, Jordan Rose wrote:
>    Alp was trying to move away from getCustomDiagID, so you should probably talk to him about this.

Thanks for pinging Jordan, that's right.

Alex, can you provide an example of how you intend to use this facility, 
say a patch making use of it with a test case to get the full picture?

There's a place for getCustomDiagID() so we wont phase it away entirely 
but I've got a feeling there might be a cleaner solution in this instance.

(As for the patch, there are a couple of nits. I'll provide an inline 
review if we do want to go with it.)


the browser experts

More information about the cfe-commits mailing list