[PATCH] Knowledge of GCC attribtues

Aaron Ballman aaron at aaronballman.com
Mon Jan 27 10:36:45 PST 2014

This patch is meant to replace one added by r199676. The goal of that
commit was to remove some specialness from thread safety attributes,
but as Richard had pointed out in IRC, there is a more correct
solution to be had: we need to encode knowledge of which attributes
are known to GCC. We already allow GNU-style attributes on function
definitions as an extension to GCC, which is what we were really
trying to (incompletely) encode with the thread-safety attribute

This patch adds a new meta-spelling called "GCC" -- it widens into
being a GNU spelling, and a CXX11 spelling with the namespace "gnu".
It also sets a bit on the spelling certifying that it is known to GCC.
>From this, we can warn about the extension appropriately. As a
consequence, the FunctionDefinition functionality is completely

-------------- next part --------------
A non-text attachment was scrubbed...
Name: KnownToGCC.patch
Type: application/octet-stream
Size: 41177 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140127/2a1b197d/attachment.obj>

More information about the cfe-commits mailing list