[PATCH] Add a -verify-pch option to clang -cc1

Ben Langmuir blangmuir at apple.com
Tue Jan 21 20:18:47 PST 2014


> Looks good!
> Could you also add a driver option (maybe "--verify-pch") ?

Sure, I’ve added -verify-pch to the driver as well.  I kept the same spelling between the two options.  The biggest change here is that we don’t want the driver to pass through -x TYPE to cc1 for an input file that is a pch when we are verifying, since we want to verify the *source* language.  Right now I am omitting "-x TYPE" when -verify-pch is set AND the input file has a .pch extension.  I’m not sure whether checking the extension is a good idea, but it is consistent with other bits of the compiler that will assume the input is an object file if it has no extension and no explicit -x option.  I’m happy to change it.

Ben

-------------- next part --------------
A non-text attachment was scrubbed...
Name: verify-pch.patch
Type: application/octet-stream
Size: 10237 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140121/8b87ad97/attachment.obj>
-------------- next part --------------





More information about the cfe-commits mailing list