[PATCH] Improve error message when a stale PCH dependency is encountered

[Argyrios Kyrtzidis]

On Jan 16, 2014, at 11:04 AM, Ben Langmuir <blangmuir at apple.com> wrote:

> On Jan 16, 2014, at 10:15 AM, Argyrios Kyrtzidis <kyrtzidis at apple.com> wrote:
>> 
>> Very nice! I like the import stack in the notes.
>> Could you also add a note saying something like "please rebuild the precompiled header ’foo.h.pch’” ?
> 
> Done.  I emitted it conditionally upon Diags.isDiagnosticsInFlight().  I wasn’t sure if that’s desired, but it seems to be the way the other notes are being emitted in this file so I did it too.

+// RUN: %clang_cc1 -x objective-c -I %S -fmodules -fmodules-cache-path=%t-dir/cache -fmodule-map-file=modified-module-dependency.module.map -emit-pch %t-dir/prefix.h -o %t-dir/prefix.pch

It’d be good to clear the module-cache-path at the beginning (rm -rf %t-dir/cache)

+// RUN: touch modified-module-dependency.module.map  

This needs to be

+// RUN: touch %S/modified-module-dependency.module.map  

so the test suite can actually find the file

> 
> Ben
> 
> <pch-error.patch>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits