r199169 - Consumed analysis: add two new attributes which fine-tune the behavior of

Aaron Ballman aaron at aaronballman.com
Wed Jan 15 14:59:35 PST 2014


On Wed, Jan 15, 2014 at 5:51 PM, Nico Weber <thakis at chromium.org> wrote:
> On Wed, Jan 15, 2014 at 2:46 PM, Aaron Ballman <aaron at aaronballman.com>
> wrote:
>>
>> On Wed, Jan 15, 2014 at 5:40 PM, Delesley Hutchins <delesley at google.com>
>> wrote:
>> >> Why is this code now commented out?
>> >
>> > It's looked "fishy" to me ;-) and it didn't break any tests when I
>> > removed it, but I left it there in case I ever discover why it was
>> > there.
>>
>> Can you put a FIXME with an explanation in then?
>
>
> Just delete it. If you remember what it's for, get it from svn. Let's not
> have uncommented code in the codebase.

That would certainly be preferable.

~Aaron



More information about the cfe-commits mailing list