[PATCH] Fix source range of destructor name

[Richard Smith]

On Wed, Jan 15, 2014 at 1:25 PM, Olivier Goffart <ogoffart at kde.org> wrote:

> Hi,
>
> This fixes http://llvm.org/bugs/show_bug.cgi?id=15125
> The problem is that destructor->getNameInfo().getSourceRange() only
> contains
> the '~' and not the class name after it.
>
> This is why for example the destructor name is not highlighted in my code
> browser, only the '~' has a tooltip.
>
> http://code.woboq.org/userspace/llvm/tools/clang/include/clang/AST/DeclarationName.h.html#_ZN5clang20Declarationisn'tNameTableD1Ev<http://code.woboq.org/userspace/llvm/tools/clang/include/clang/AST/DeclarationName.h.html#_ZN5clang20DeclarationNameTableD1Ev>


+            return CreateParsedType(MemberOfType,
+                    Context.getTrivialTypeSourceInfo(MemberOfType,
NameLoc));
             return ParsedType::make(MemberOfType);

Please delete the unreachable 'return' statement here.

There are 3 other 'return ParsedType::make(...);' calls in this function,
and they all seem to have the same issue; do these need changes too? Also,
you aren't including the location information from the CXXScopeSpec in the
produced TypeSourceInfo, so this still doesn't look exactly right (for
p->X::Y::~Y(), you probably won't be able to provide an appropriate tooltip
for the 'X', even with this fix, for instance).

The changes to DeclarationName.cpp and to DeclPrinterTest.cpp look
unrelated to this fix (right?), and the fix itself seems to be missing a
test.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140115/fe8fdbe1/attachment.html>