r199175 - Removing some attribute magic related to the OpenCL keyword attributes. Instead of mapping them to their semantics as a custom part of the parser, they instead map declaratively through the rest of the attribute system.

[Aaron Ballman]

After discussing on IRC, I committed r199229 which addresses this and
simplifies the attribute a bit further. Thank you for bringing it to
my attention!

~Aaron

On Tue, Jan 14, 2014 at 8:09 AM, Aaron Ballman <aaron at aaronballman.com> wrote:
> On Tue, Jan 14, 2014 at 5:37 AM, Joey Gouly <joey.gouly at arm.com> wrote:
>> Thanks Aaron, this is a nice cleanup!
>>
>> It's worth noting that a user can still write
>> __attribute__((opencl_image_access(N)), which we probably want to disallow.
>> Alp said you might already know about this kind of issue?
>
> Nope, this is the first I've heard of it, so thank you for bringing it
> up! Are you saying that opencl_image_access(N) isn't meant to be
> written (only the keywords are meant to be used)?
>
> Thanks!
>
> ~Aaron