r199076 - [CMake] Move BUG_REPORT_URL from clang to llvm.

NAKAMURA Takumi geek4civic at gmail.com
Mon Jan 13 15:17:55 PST 2014


I missed standalone build.

For now, I guess empty(undefined) BUG_REPORT_URL would not affect to build.
That said, it'd be better to configure BUG_REPORT_URL in clang side.

2014/1/14 Jordan Rose <jordan_rose at apple.com>:
>
> On Jan 13, 2014, at 10:01 , Reid Kleckner <rnk at google.com> wrote:
>
> On Mon, Jan 13, 2014 at 9:14 AM, Jordan Rose <jordan_rose at apple.com> wrote:
>>
>>
>> On Jan 12, 2014, at 21:25 , NAKAMURA Takumi <geek4civic at gmail.com> wrote:
>>
>> > Author: chapuni
>> > Date: Sun Jan 12 23:25:13 2014
>> > New Revision: 199076
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=199076&view=rev
>> > Log:
>> > [CMake] Move BUG_REPORT_URL from clang to llvm.
>> >
>> > It was too late to set BUG_REPORT_URL after configure_file(config.h).
>> > BUG_REPORT_URL in config.h.cmake would be updated at 2nd run of cmake.
>> > It caused many recompilations.
>> >
>> > FYI, configure handles BUG_REPORT_URL in llvm side.
>> >
>> > Modified:
>> >    cfe/trunk/CMakeLists.txt
>> >
>> > Modified: cfe/trunk/CMakeLists.txt
>> > URL:
>> > http://llvm.org/viewvc/llvm-project/cfe/trunk/CMakeLists.txt?rev=199076&r1=199075&r2=199076&view=diff
>> >
>> > ==============================================================================
>> > --- cfe/trunk/CMakeLists.txt (original)
>> > +++ cfe/trunk/CMakeLists.txt Sun Jan 12 23:25:13 2014
>> > @@ -451,8 +451,5 @@ if( CLANG_BUILT_STANDALONE AND MSVC_VERS
>> >   endif()
>> > endif()
>> >
>> > -set(BUG_REPORT_URL "http://llvm.org/bugs/" CACHE STRING
>> > -  "Default URL where bug reports are to be submitted.")
>> > -
>>
>> What about standalone builds?
>
>
> Sounds like you'd have to set BUG_REPORT_URL when building LLVM instead of
> Clang.  Is that OK?  If not, we should move it out of LLVM's config header.
>
>
> That's...not the best behavior, but I guess it's all right. (Consider
> someone distributing a custom Clang built against a platform LLVM.) Was just
> worried that there'd be no default anymore.
>
> Jordan



More information about the cfe-commits mailing list