[PATCH] [ms-cxxabi] Elide dtor access checks for pass-by-val objects in callees
richard at metafoo.co.uk
Thu Jan 9 16:08:10 PST 2014
I think you should only be removing the direct access check of the parameter type, and not handling the base and member access checks -- they're effectively part of generating the destructor definition for the parameter's type, and aren't affected by which TU the check is performed in.
> I don't think we should elide these checks. This would lead us to behave
> differently than MSVC inside of SFINAE contexts.
If I understand correctly, these checks only occur as part of handling a function definition, which is not a SFINAE context, so I think this is not an issue.
More information about the cfe-commits