r198858 - Disable LeakSanitizer in TableGen binaries, see PR18325

Alp Toker alp at nuanti.com
Thu Jan 9 12:46:27 PST 2014

On 09/01/2014 20:36, Sean Silva wrote:
> On Thu, Jan 9, 2014 at 4:44 AM, Alp Toker <alp at nuanti.com 
> <mailto:alp at nuanti.com>> wrote:
>     Kostya's commit is the only instance I can find of this violation
>     in dozens of large software projects.
> You may want to update your checker to look for _[A-Z] names...

Yes, will do.

Early findings suggest there's an order of value / diminishing risk of 
conflict, with define/undefine of reserved macros the most important to 
diagnose, then "__" prefixed identifiers (the case discussed here), 
followed by " _[A-Z]" and finally "__" as a substring of the identifier.

The checks take into account visibility and only get run on global names 
as per the specification so even with the full set of rules implemented 
there isn't much noise. The hits so far have been legitimate.


> -- Sean Silva

the browser experts

More information about the cfe-commits mailing list