[cfe-dev] [PATCH] Preserve -fretain-comments-from-system-headers in modules

[Argyrios Kyrtzidis]

On Jan 9, 2014, at 9:08 AM, Ben Langmuir <blangmuir at apple.com> wrote:

> [moving to cfe-commits]
> 
>> I think that serialization is automatically handled for all options
>> defined in LangOptions.def (ASTWriter::WriteControlBlock).  But
>> because this is a BENIGN_LANGOPT, ASTReader seems to skip checking
>> that they match.
> 
> Hmm, I was worried about changing this option from BENIGN_LANGOPT to LANGOPT because it would affect other code, but now that I look at it more closely it seems to do just what I want.

Yes, this seems the right way to go.

>   Additionally langopt also adds this flag to -module-file-info, which seems like a good thing.  I’ve attached an updated patch that switches to LANGOPT.<module-system-header-comments.patch>

LGTM!

> 
> Ben
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits