[cfe-dev] [PATCH] Preserve -fretain-comments-from-system-headers in modules

Ben Langmuir blangmuir at apple.com
Thu Jan 9 09:08:14 PST 2014

[moving to cfe-commits]

> I think that serialization is automatically handled for all options
> defined in LangOptions.def (ASTWriter::WriteControlBlock).  But
> because this is a BENIGN_LANGOPT, ASTReader seems to skip checking
> that they match.

Hmm, I was worried about changing this option from BENIGN_LANGOPT to LANGOPT because it would affect other code, but now that I look at it more closely it seems to do just what I want.   Additionally langopt also adds this flag to -module-file-info, which seems like a good thing.  I’ve attached an updated patch that switches to LANGOPT.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: module-system-header-comments.patch
Type: application/octet-stream
Size: 2734 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140109/f5ae853d/attachment.obj>
-------------- next part --------------


More information about the cfe-commits mailing list