[clang-tools-extra] r198703 - Run llvm/utils/sort_includes.py over the Clang tools code. This doesn't

Cody Maloney cmaloney at theoreticalchaos.com
Tue Jan 7 13:16:35 PST 2014


Just one looks actually broken / incorrect:
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/modularize/Modularize.cpp?rev=198703&r1=198702&r2=198703&view=diff

It looks like the API header search in sort_includes.py is broken/incorrect
in this case. It assumes the first include in any 'cpp' file is correct
even if it does not match name or section at all. The script should
probably search for a matching name in the last chunk of the path (Although
one header with multiple implementing independently named cpp files would
break it then)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140107/de621f88/attachment.html>


More information about the cfe-commits mailing list