[patch?] Write Version.inc at cmake time, not at build time

[Chandler Carruth]

Sorry, I completely misread your email and thought you were trying to fix
something new. Thanks for the clue-bat in IRC. =]

I see this is actually just trying to finish cleaning up the added
complexity that didn't quite get finished when Jordan was working on it and
brings Clang in line for LLVM.

LGTM


On Tue, Jan 7, 2014 at 1:06 AM, Chandler Carruth <chandlerc at google.com>wrote:

> Is it possible to generate Version.inc every time the the VCS changes? I
> know this is a little silly, but I really like having assurances that if
> there is a revision number is is correct, and it seems likely to be very
> fast to test with git at least, and maybe svn.
>
>
> On Tue, Jan 7, 2014 at 1:02 AM, Nico Weber <thakis at chromium.org> wrote:
>
>> Hi,
>>
>> I'm seeing a cmake invocation to generate Version.inc on every build,
>> even if nothing else needs to be done. r191784 claimed to undo that, but it
>> doesn't work for me – and as far as I understand, Version.inc is still
>> created through an always-dirty build edge at the moment, so I don't
>> understand how this couldn't run on every build either.
>>
>> The attached patch changes things so that Version.inc is written at cmake
>> time. With this, I get empty builds that don't run any build steps.
>>
>> Nico
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140107/992521ca/attachment.html>