[PATCH] Initial instrumentation based PGO implementation

Eric Christopher echristo at gmail.com
Mon Jan 6 14:55:41 PST 2014

You should wait for an explicit ack on committing a patch if it's in
review. It's a bit anti-social to do so otherwise and that people are
waiting isn't a good enough reason to skip that.

In addition, asking you to improve the comments was a way of getting a
better explanation of the code without having it tied up in email - if I
have to ask then so would someone else. I may have other feedback for you
after the comments are added.


On Mon Jan 06 2014 at 2:36:28 PM, Justin Bogner <mail at justinbogner.com>

> Justin Bogner <mail at justinbogner.com> writes:
> > Since we're basically just improving comments at this point, and since
> > this not being in has been blocking other people trying to use and
> > build on top of these changes, I'm going to go ahead and commit
> > now. I'll continue to incorporate further feedback in follow on
> > commits.
> r198638, r198639, and r198640.
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140106/f6cb5444/attachment.html>

More information about the cfe-commits mailing list