[PATCH] MachO-embedded: refactor Clang to use "*-*-unknown-macho" triple

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Mon Jan 6 14:04:42 PST 2014

  The patch is OK by me.

  It is all MachO specific, so I would suggest getting someone at Apple to take another look. Another thing you might want to do is to split the patch a bit to make it easier to read. Some possible sub patches.

  * Rename DarwinTool to MachOTool.
  * Update the method names to start with a lowercase letter.

Comment at: lib/Driver/ToolChains.h:214
@@ +213,3 @@
+  /// Add the linker arguments to link the ARC runtime library.
+  virtual void addLinkARCArgs(const llvm::opt::ArgList &Args,
+                              llvm::opt::ArgStringList &CmdArgs) const {}
nit: Usually there is no advantage in having inline virtual methods (other than the destructor) in non final classes.


More information about the cfe-commits mailing list