r198387 - Removing some more unnecessary manual quotes from attribute diagnostics.

Aaron Ballman aaron at aaronballman.com
Thu Jan 2 17:09:27 PST 2014


Author: aaronballman
Date: Thu Jan  2 19:09:27 2014
New Revision: 198387

URL: http://llvm.org/viewvc/llvm-project?rev=198387&view=rev
Log:
Removing some more unnecessary manual quotes from attribute diagnostics.

Modified:
    cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
    cfe/trunk/lib/Sema/SemaPseudoObject.cpp
    cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp

Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=198387&r1=198386&r2=198387&view=diff
==============================================================================
--- cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (original)
+++ cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Thu Jan  2 19:09:27 2014
@@ -1952,12 +1952,12 @@ def warn_mismatched_section : Warning<
 
 def err_anonymous_property: Error<
   "anonymous property is not supported">;
-def err_property_is_variably_modified: Error<
-  "property '%0' has a variably modified type">;
+def err_property_is_variably_modified : Error<
+  "property %0 has a variably modified type">;
 def err_no_accessor_for_property : Error<
-  "no %select{getter|setter}0 defined for property '%1'">;
+  "no %select{getter|setter}0 defined for property %1">;
 def error_cannot_find_suitable_accessor : Error<
-  "cannot find suitable %select{getter|setter}0 for property '%1'">;
+  "cannot find suitable %select{getter|setter}0 for property %1">;
 
 def err_attribute_aligned_not_power_of_two : Error<
   "requested alignment is not a power of 2">;

Modified: cfe/trunk/lib/Sema/SemaPseudoObject.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaPseudoObject.cpp?rev=198387&r1=198386&r2=198387&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaPseudoObject.cpp (original)
+++ cfe/trunk/lib/Sema/SemaPseudoObject.cpp Thu Jan  2 19:09:27 2014
@@ -1394,7 +1394,7 @@ Expr *MSPropertyOpBuilder::rebuildAndCap
 ExprResult MSPropertyOpBuilder::buildGet() {
   if (!RefExpr->getPropertyDecl()->hasGetter()) {
     S.Diag(RefExpr->getMemberLoc(), diag::err_no_accessor_for_property)
-      << 0 /* getter */ << RefExpr->getPropertyDecl()->getName();
+      << 0 /* getter */ << RefExpr->getPropertyDecl();
     return ExprError();
   }
 
@@ -1410,7 +1410,7 @@ ExprResult MSPropertyOpBuilder::buildGet
   if (GetterExpr.isInvalid()) {
     S.Diag(RefExpr->getMemberLoc(),
            diag::error_cannot_find_suitable_accessor) << 0 /* getter */
-      << RefExpr->getPropertyDecl()->getName();
+      << RefExpr->getPropertyDecl();
     return ExprError();
   }
 
@@ -1424,7 +1424,7 @@ ExprResult MSPropertyOpBuilder::buildSet
                                          bool captureSetValueAsResult) {
   if (!RefExpr->getPropertyDecl()->hasSetter()) {
     S.Diag(RefExpr->getMemberLoc(), diag::err_no_accessor_for_property)
-      << 1 /* setter */ << RefExpr->getPropertyDecl()->getName();
+      << 1 /* setter */ << RefExpr->getPropertyDecl();
     return ExprError();
   }
 
@@ -1440,7 +1440,7 @@ ExprResult MSPropertyOpBuilder::buildSet
   if (SetterExpr.isInvalid()) {
     S.Diag(RefExpr->getMemberLoc(),
            diag::error_cannot_find_suitable_accessor) << 1 /* setter */
-      << RefExpr->getPropertyDecl()->getName();
+      << RefExpr->getPropertyDecl();
     return ExprError();
   }
 

Modified: cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp?rev=198387&r1=198386&r2=198387&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp (original)
+++ cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp Thu Jan  2 19:09:27 2014
@@ -476,7 +476,7 @@ Decl *TemplateDeclInstantiator::VisitMSP
 
   if (DI->getType()->isVariablyModifiedType()) {
     SemaRef.Diag(D->getLocation(), diag::err_property_is_variably_modified)
-    << D->getName();
+      << D;
     Invalid = true;
   } else if (DI->getType()->isInstantiationDependentType())  {
     DI = SemaRef.SubstType(DI, TemplateArgs,





More information about the cfe-commits mailing list