r198373 - This diagnostic should not have had the manual quotation marks. Its only usage passed in an Attr object, which was already quoted when printing the diagnostic. However, there was no test case that caught this bug -- one has been added.

Aaron Ballman aaron at aaronballman.com
Thu Jan 2 15:22:40 PST 2014


Author: aaronballman
Date: Thu Jan  2 17:22:40 2014
New Revision: 198373

URL: http://llvm.org/viewvc/llvm-project?rev=198373&view=rev
Log:
This diagnostic should not have had the manual quotation marks. Its only usage passed in an Attr object, which was already quoted when printing the diagnostic. However, there was no test case that caught this bug -- one has been added.

Added:
    cfe/trunk/test/SemaCXX/cxx-altivec.cpp
Modified:
    cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=198373&r1=198372&r2=198373&view=diff
==============================================================================
--- cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (original)
+++ cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Thu Jan  2 17:22:40 2014
@@ -1579,7 +1579,7 @@ def warn_abstract_final_class : Warning<
   "abstract class is marked '%select{final|sealed}0'">, InGroup<AbstractFinalClass>;
 
 // C++11 attributes
-def err_repeat_attribute : Error<"'%0' attribute cannot be repeated">;
+def err_repeat_attribute : Error<"%0 attribute cannot be repeated">;
 
 // C++11 final
 def err_final_function_overridden : Error<

Added: cfe/trunk/test/SemaCXX/cxx-altivec.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/cxx-altivec.cpp?rev=198373&view=auto
==============================================================================
--- cfe/trunk/test/SemaCXX/cxx-altivec.cpp (added)
+++ cfe/trunk/test/SemaCXX/cxx-altivec.cpp Thu Jan  2 17:22:40 2014
@@ -0,0 +1,5 @@
+// RUN: %clang_cc1 -triple=powerpc-apple-darwin8 -faltivec -fsyntax-only -verify %s
+
+struct Vector {
+	__vector float xyzw;
+} __attribute__((vecreturn)) __attribute__((vecreturn));  // expected-error {{'vecreturn' attribute cannot be repeated}}





More information about the cfe-commits mailing list